Skip to content

uemacs: fix cross#407243

Merged
siraben merged 1 commit intoNixOS:masterfrom
siraben:uemacs-cross
May 15, 2025
Merged

uemacs: fix cross#407243
siraben merged 1 commit intoNixOS:masterfrom
siraben:uemacs-cross

Conversation

@siraben
Copy link
Member

@siraben siraben commented May 15, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • pkgsCross.aarch64-multiplatform
    • pkgsCross.riscv64
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label May 15, 2025
@siraben

This comment was marked as outdated.

Sign in to view
@siraben
Copy link
Member Author

siraben commented May 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407243 --package pkgsCross.riscv64.uemacs --package pkgsCross.aarch64-multiplatform.uemacs

x86_64-linux

✅ 2 packages built:
  • pkgsCross.aarch64-multiplatform.uemacs
  • pkgsCross.riscv64.uemacs

@siraben siraben merged commit 165e66a into NixOS:master May 15, 2025
24 of 28 checks passed
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 15, 2025
@nix-owners nix-owners bot requested a review from networkException May 15, 2025 04:41
@winterqt
Copy link
Member

winterqt commented May 15, 2025

Please don't self-merge that quickly in the future, especially with failing CI. This broke CI for a number of packages (fixed in #407248).

You generally should also give the maintainer time to respond.

@networkException
Copy link
Member

networkException commented May 15, 2025

Indeed you left me with no opportunity to review the last two pull requests, not even letting CI review request me here before merging. All of this in 12 hours is not what I expect from a committer interacting with a package I maintain

@siraben siraben deleted the uemacs-cross branch May 16, 2025 00:47
@siraben
Copy link
Member Author

siraben commented May 16, 2025

@winterqt @networkException noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@networkException networkException Awaiting requested review from networkException

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siraben @winterqt @networkException